Implement new Pip Layout (with control buttons)

This commit is contained in:
Timo K
2026-03-04 16:47:15 +01:00
parent c98d03e2e1
commit 8db1c4c370
5 changed files with 48 additions and 23 deletions

View File

@@ -23,6 +23,7 @@ import styles from "./Button.module.css";
interface MicButtonProps extends ComponentPropsWithoutRef<"button"> { interface MicButtonProps extends ComponentPropsWithoutRef<"button"> {
muted: boolean; muted: boolean;
size: "sm" | "lg";
} }
export const MicButton: FC<MicButtonProps> = ({ muted, ...props }) => { export const MicButton: FC<MicButtonProps> = ({ muted, ...props }) => {
@@ -47,6 +48,7 @@ export const MicButton: FC<MicButtonProps> = ({ muted, ...props }) => {
interface VideoButtonProps extends ComponentPropsWithoutRef<"button"> { interface VideoButtonProps extends ComponentPropsWithoutRef<"button"> {
muted: boolean; muted: boolean;
size: "sm" | "lg";
} }
export const VideoButton: FC<VideoButtonProps> = ({ muted, ...props }) => { export const VideoButton: FC<VideoButtonProps> = ({ muted, ...props }) => {
@@ -71,6 +73,7 @@ export const VideoButton: FC<VideoButtonProps> = ({ muted, ...props }) => {
interface ShareScreenButtonProps extends ComponentPropsWithoutRef<"button"> { interface ShareScreenButtonProps extends ComponentPropsWithoutRef<"button"> {
enabled: boolean; enabled: boolean;
size: "sm" | "lg";
} }
export const ShareScreenButton: FC<ShareScreenButtonProps> = ({ export const ShareScreenButton: FC<ShareScreenButtonProps> = ({
@@ -94,7 +97,11 @@ export const ShareScreenButton: FC<ShareScreenButtonProps> = ({
); );
}; };
export const EndCallButton: FC<ComponentPropsWithoutRef<"button">> = ({ interface EndCallButtonProps extends ComponentPropsWithoutRef<"button"> {
size: "sm" | "lg";
}
export const EndCallButton: FC<EndCallButtonProps> = ({
className, className,
...props ...props
}) => { }) => {

View File

@@ -108,22 +108,9 @@ Please see LICENSE in the repository root for full details.
} }
} }
@media (max-width: 370px) { @media (max-height: 800px) {
.shareScreen { .footer {
display: none; padding-block: var(--cpd-space-8x);
}
@media (max-height: 400px) {
.footer {
display: none;
}
}
}
@media (max-width: 320px) {
.invite,
.raiseHand {
display: none;
} }
} }
@@ -133,9 +120,27 @@ Please see LICENSE in the repository root for full details.
} }
} }
@media (max-height: 800px) { @media (max-width: 370px) {
.footer { .shareScreen {
padding-block: var(--cpd-space-8x); display: none;
}
/* PIP custom css */
@media (max-height: 400px) {
.shareScreen {
display: flex;
}
.footer {
padding-block-start: var(--cpd-space-3x);
padding-block-end: var(--cpd-space-2x);
}
}
}
@media (max-width: 320px) {
.invite,
.raiseHand {
display: none;
} }
} }

View File

@@ -640,8 +640,10 @@ export const InCallView: FC<InCallViewProps> = ({
const buttons: JSX.Element[] = []; const buttons: JSX.Element[] = [];
const buttonSize = layout.type === "pip" ? "sm" : "lg";
buttons.push( buttons.push(
<MicButton <MicButton
size={buttonSize}
key="audio" key="audio"
muted={!audioEnabled} muted={!audioEnabled}
onClick={toggleAudio ?? undefined} onClick={toggleAudio ?? undefined}
@@ -649,6 +651,7 @@ export const InCallView: FC<InCallViewProps> = ({
data-testid="incall_mute" data-testid="incall_mute"
/>, />,
<VideoButton <VideoButton
size={buttonSize}
key="video" key="video"
muted={!videoEnabled} muted={!videoEnabled}
onClick={toggleVideo ?? undefined} onClick={toggleVideo ?? undefined}
@@ -659,6 +662,7 @@ export const InCallView: FC<InCallViewProps> = ({
if (vm.toggleScreenSharing !== null) { if (vm.toggleScreenSharing !== null) {
buttons.push( buttons.push(
<ShareScreenButton <ShareScreenButton
size={buttonSize}
key="share_screen" key="share_screen"
className={styles.shareScreen} className={styles.shareScreen}
enabled={sharingScreen} enabled={sharingScreen}
@@ -670,6 +674,7 @@ export const InCallView: FC<InCallViewProps> = ({
if (supportsReactions) { if (supportsReactions) {
buttons.push( buttons.push(
<ReactionToggleButton <ReactionToggleButton
size={buttonSize}
vm={vm} vm={vm}
key="raise_hand" key="raise_hand"
className={styles.raiseHand} className={styles.raiseHand}
@@ -678,10 +683,17 @@ export const InCallView: FC<InCallViewProps> = ({
); );
} }
if (layout.type !== "pip") if (layout.type !== "pip")
buttons.push(<SettingsButton key="settings" onClick={openSettings} />); buttons.push(
<SettingsButton
size={buttonSize}
key="settings"
onClick={openSettings}
/>,
);
buttons.push( buttons.push(
<EndCallButton <EndCallButton
size={buttonSize}
key="end_call" key="end_call"
onClick={function (): void { onClick={function (): void {
vm.hangup(); vm.hangup();

View File

@@ -1271,7 +1271,7 @@ export function createCallViewModel$(
switchMap((mode) => { switchMap((mode) => {
switch (mode) { switch (mode) {
case "pip": case "pip":
return of(false); return of(true);
case "normal": case "normal":
case "narrow": case "narrow":
return of(true); return of(true);

View File

@@ -16,7 +16,8 @@ export function pipLayout(
prevTiles: TileStore, prevTiles: TileStore,
): [PipLayout, TileStore] { ): [PipLayout, TileStore] {
const update = prevTiles.from(0); const update = prevTiles.from(0);
update.registerSpotlight(media.spotlight, true); // Dont maximise in pip since we want the rounded corners and the footer
update.registerSpotlight(media.spotlight, false);
const tiles = update.build(); const tiles = update.build();
return [ return [
{ {