* Refactor media devices to live outside React as Observables This moves the media devices state out of React to further our transition to a MVVM architecture in which we can more easily model and store complex application state. I have created an AppViewModel to act as the overarching state holder for any future non-React state we end up creating, and the MediaDevices reside within this. We should move more application logic (including the CallViewModel itself) there in the future. * Address review feedback * Fixes from ios debugging session: (#3342) - dont use preferred vs selected concept in controlled media. Its not needed since we dont use the id for actual browser media devices (the id's are not even actual browser media devices) - add more logging - add more conditions to not accidently set a deviceId that is not a browser deviceId but one provided via controlled. --------- Co-authored-by: Timo <16718859+toger5@users.noreply.github.com>
118 lines
3.7 KiB
TypeScript
118 lines
3.7 KiB
TypeScript
/*
|
|
Copyright 2023, 2024 New Vector Ltd.
|
|
|
|
SPDX-License-Identifier: AGPL-3.0-only OR LicenseRef-Element-Commercial
|
|
Please see LICENSE in the repository root for full details.
|
|
*/
|
|
|
|
import { afterEach, beforeEach, expect, it, vi } from "vitest";
|
|
import { render } from "@testing-library/react";
|
|
import { type CallMembership } from "matrix-js-sdk/lib/matrixrtc";
|
|
import {
|
|
getTrackReferenceId,
|
|
type TrackReference,
|
|
} from "@livekit/components-core";
|
|
import { type RemoteAudioTrack } from "livekit-client";
|
|
import { type ReactNode } from "react";
|
|
import { useTracks } from "@livekit/components-react";
|
|
|
|
import { testAudioContext } from "../useAudioContext.test";
|
|
import * as MediaDevicesContext from "../MediaDevicesContext";
|
|
import { MatrixAudioRenderer } from "./MatrixAudioRenderer";
|
|
import { mockMediaDevices, mockTrack } from "../utils/test";
|
|
|
|
export const TestAudioContextConstructor = vi.fn(() => testAudioContext);
|
|
|
|
const MediaDevicesProvider = MediaDevicesContext.MediaDevicesContext.Provider;
|
|
|
|
beforeEach(() => {
|
|
vi.stubGlobal("AudioContext", TestAudioContextConstructor);
|
|
});
|
|
|
|
afterEach(() => {
|
|
vi.unstubAllGlobals();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
vi.mock("@livekit/components-react", async (importOriginal) => {
|
|
return {
|
|
...(await importOriginal()),
|
|
AudioTrack: (props: { trackRef: TrackReference }): ReactNode => {
|
|
return (
|
|
<audio data-testid={"audio"}>
|
|
{getTrackReferenceId(props.trackRef)}
|
|
</audio>
|
|
);
|
|
},
|
|
useTracks: vi.fn(),
|
|
};
|
|
});
|
|
|
|
const tracks = [mockTrack("test:123")];
|
|
vi.mocked(useTracks).mockReturnValue(tracks);
|
|
|
|
it("should render for member", () => {
|
|
const { container, queryAllByTestId } = render(
|
|
<MediaDevicesProvider value={mockMediaDevices({})}>
|
|
<MatrixAudioRenderer
|
|
members={[{ sender: "test", deviceId: "123" }] as CallMembership[]}
|
|
/>
|
|
</MediaDevicesProvider>,
|
|
);
|
|
expect(container).toBeTruthy();
|
|
expect(queryAllByTestId("audio")).toHaveLength(1);
|
|
});
|
|
|
|
it("should not render without member", () => {
|
|
const memberships = [
|
|
{ sender: "othermember", deviceId: "123" },
|
|
] as CallMembership[];
|
|
const { container, queryAllByTestId } = render(
|
|
<MediaDevicesProvider value={mockMediaDevices({})}>
|
|
<MatrixAudioRenderer members={memberships} />
|
|
</MediaDevicesProvider>,
|
|
);
|
|
expect(container).toBeTruthy();
|
|
expect(queryAllByTestId("audio")).toHaveLength(0);
|
|
});
|
|
|
|
it("should not setup audioContext gain and pan if there is no need to.", () => {
|
|
render(
|
|
<MediaDevicesProvider value={mockMediaDevices({})}>
|
|
<MatrixAudioRenderer
|
|
members={[{ sender: "test", deviceId: "123" }] as CallMembership[]}
|
|
/>
|
|
</MediaDevicesProvider>,
|
|
);
|
|
const audioTrack = tracks[0].publication.track! as RemoteAudioTrack;
|
|
|
|
expect(audioTrack.setAudioContext).toHaveBeenCalledTimes(1);
|
|
expect(audioTrack.setAudioContext).toHaveBeenCalledWith(undefined);
|
|
expect(audioTrack.setWebAudioPlugins).toHaveBeenCalledTimes(1);
|
|
expect(audioTrack.setWebAudioPlugins).toHaveBeenCalledWith([]);
|
|
|
|
expect(testAudioContext.gain.gain.value).toEqual(1);
|
|
expect(testAudioContext.pan.pan.value).toEqual(0);
|
|
});
|
|
|
|
it("should setup audioContext gain and pan", () => {
|
|
vi.spyOn(MediaDevicesContext, "useEarpieceAudioConfig").mockReturnValue({
|
|
pan: 1,
|
|
volume: 0.1,
|
|
});
|
|
render(
|
|
<MediaDevicesProvider value={mockMediaDevices({})}>
|
|
<MatrixAudioRenderer
|
|
members={[{ sender: "test", deviceId: "123" }] as CallMembership[]}
|
|
/>
|
|
</MediaDevicesProvider>,
|
|
);
|
|
|
|
const audioTrack = tracks[0].publication.track! as RemoteAudioTrack;
|
|
expect(audioTrack.setAudioContext).toHaveBeenCalled();
|
|
expect(audioTrack.setWebAudioPlugins).toHaveBeenCalled();
|
|
|
|
expect(testAudioContext.gain.gain.value).toEqual(0.1);
|
|
expect(testAudioContext.pan.pan.value).toEqual(1);
|
|
});
|